Use String::resize() and CharString in text_server_adv again #80642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bruvzg approved these changes Aug 15, 2023
akien-mga changed the title String::resize() and CharString in text_server_adv againString::resize() and CharString in text_server_adv again 
Member
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Shortly before 4.1 was released, PR #77532 added some workarounds to allow the
text_server_advmodule to keep compiling as a GDExtension, by avoidingString::resize()andCharStringwhich were missing or broken in godot-cpp at the time.However, after PR godotengine/godot-cpp#1166 and PR godotengine/godot-cpp#1150 this should no longer be necessary!
This PR reverts the workaround bits that were in PR #77532