Skip to content

Fix -Wmissing-braces warning (included in -Wall) in array constructor for generated function call bindings #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fix -Wmissing-braces warning (included in -Wall) in array constructor for generated function call bindings #1704

merged 1 commit into from
Mar 13, 2025

Conversation

@BenLubar
Copy link
Contributor

@BenLubar BenLubar commented Feb 9, 2025

No description provided.

@BenLubar BenLubar requested a review from a team as a code owner February 9, 2025 23:21
@Bromeon
Copy link
Contributor

Bromeon commented Feb 10, 2025

If -Wall is a desired configuration to support, should it be checked in CI?
@Calinou Calinou added the bug This has been identified as a bug label Feb 10, 2025
dsnopek
dsnopek approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems fine - I agree with Bromeon, though, that if this is important to us (which I'm not sure it is) we should have it in CI. But I don't think that should hold up merging this.
@dsnopek dsnopek merged commit 6f981b3 into godotengine:master Mar 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug

4 participants

@BenLubar @Bromeon @dsnopek @Calinou