Skip to content

Conversation

@aaronfranke
Copy link
Member

This was accidentally missed when PackedVector4Array was added to godot-cpp: #1456

Without this PR, it is not possible to bind methods using PackedVector4Array with ClassDB::bind_method.

4.3 milestone because this is a vital bugfix for a new 4.3 feature and it would be a shame to release 4.3 without this.

@aaronfranke aaronfranke added the bug This has been identified as a bug label Aug 11, 2024
@aaronfranke aaronfranke added this to the 4.3 milestone Aug 11, 2024
@aaronfranke aaronfranke requested a review from a team as a code owner August 11, 2024 04:24
Copy link
Contributor

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice last minute catch 👍

Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 9b98377 into godotengine:master Aug 11, 2024
@aaronfranke aaronfranke deleted the fix-vec4arr branch August 11, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug

3 participants