Skip to content

Add Vector2i/3i/4i methods: distance_to and distance_squared_to #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add Vector2i/3i/4i methods: distance_to and distance_squared_to #1347

merged 1 commit into from
Jan 4, 2024

Conversation

@Chubercik
Copy link
Contributor

This pull request adds distance_to and distance_squared_to methods for Vector2i, Vector3i and Vector4i, so that godot-cpp may remain in parity with GDScript.
@Chubercik Chubercik requested a review from a team as a code owner January 3, 2024 02:01
@dsnopek dsnopek added waiting for Godot PRs that can't be merged until an engine PR is merged first enhancement This is an enhancement on the current functionality labels Jan 3, 2024
@dsnopek dsnopek added this to the 4.x milestone Jan 3, 2024
@AThousandShips AThousandShips removed the waiting for Godot PRs that can't be merged until an engine PR is merged first label Jan 3, 2024
AThousandShips
AThousandShips approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and parity is great! Thank you 🎉
dsnopek
dsnopek approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me too :-)
@dsnopek dsnopek merged commit dd62b96 into godotengine:master Jan 4, 2024
@dsnopek
Copy link
Collaborator

dsnopek commented Jan 4, 2024

Thanks! And congrats for your first merged Godot contribution 🎉
@Chubercik Chubercik deleted the vector_method_parity branch January 4, 2024 15:06
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality

4 participants

@Chubercik @dsnopek @AThousandShips @akien-mga