Fix file list issues when trying to build with meson via cmake #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dsnopek added topic:buildsystem 
dsnopek approved these changes Nov 15, 2023
There was a problem hiding this comment.
Thanks!
The change to binding_generator.py looks good to me. Personally, I'm not super familiar with cmake, but I tried building with cmake and make and everything seemed to still work fine. (Unfortunately, I don't know how to test with Meson, but nothing here is Meson specific, so I think that's fine.)
| Thanks! |
| Cherry-picking to 4.1 in #1373 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While attempting to build this project with meson (via its cmake module) I ran into an issue with the generated file listing having a trailing
;and trailing whitespace, which meson doesn't handle very well. This PR fixes these issues.