Fix is_msvc and use_hot_reload variables #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dsnopek added bug 
dsnopek approved these changes Nov 8, 2023
| Thanks! |
| Cherry-picked for 4.1 in PR #1306 |
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Extracted from #1289
Fixes #1297
Fixes two variables that weren't loading their values correctly:
is_msvcanduse_hot_reload. The former didn't properly apply todisable_exceptionsbecause it was previously evaluated before the windows target was parsed, so the expression was relocated with no further changes. The latter failed to evaluate the conditional properly, even if a value was provided via cla, so its fallback was changed toNone& the logic was migrated to just before the variable is first used.