Update for addition of get_virtual_call_data_func and call_virtual_func to GDExtensionClassCreationInfo2 #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…_func` to `GDExtensionClassCreationInfo2`
| CI failed, but I think it's because a new artifact still hasn't been built on the Godot Here's the Godot build: https://github.com/godotengine/godot/actions/runs/6251725462/ |
| It's passing CI using the latest Godot artifacts! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This allows godot-cpp to continue working after merging Godot PR godotengine/godot#80671
godot-cpp doesn't actually need the feature added in that PR; it's for languages that don't have a way to automatically generate new functions with C linkage, whereas C++ can do that just fine. But since that PR adds two new fields to the
GDExtensionClassCreationInfo2struct, so we need to set them tonullptrin order to keep working with Godotmaster.