Skip to content

Conversation

@Zylann
Copy link
Collaborator

@Zylann Zylann commented Jul 26, 2023

Generates a core/version.hpp file with macros similar to Godot's core VERSION_*. This allows to do conditional compilation in case of compatibility breakage between Godot versions.

@Zylann Zylann requested a review from a team as a code owner July 26, 2023 22:18
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great to me :-)

@dsnopek
Copy link
Collaborator

dsnopek commented Aug 11, 2023

Discussed at the GDExtension meeting. There was some discussion around the defines being prefixed with GODOT_ versus their counterparts in Godot itself, but we think this is fine as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants