Skip to content

chore: dependency upgrades, import order, and no one-line if statements #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rickharris merged 4 commits into from
Jan 13, 2020
Merged

chore: dependency upgrades, import order, and no one-line if statements #19

rickharris merged 4 commits into from
Jan 13, 2020

Conversation

@rickharris
Copy link
Contributor

@rickharris rickharris commented Jan 10, 2020

This PR:

  • Updates us to the latest eslint-config-react-app and other dependencies
  • Adds auto-fixable import order lint rule that works with our webpack aliases
  • Adds Enforce curly braces for all if statements #13 (already approved, just incorporated it into this PR for testing autofix with prettier updates and import order all together)

The effects of these changes can be seen in https://github.com/goabstract/ui/pull/2340
@rickharris rickharris requested review from timc1 and tommoor January 10, 2020 00:22
tommoor
tommoor approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'll miss my one-liners, but onboard for the greater good.
@rickharris rickharris merged commit a2f29a5 into master Jan 13, 2020
@rickharris rickharris deleted the upgrades-jan-2020 branch January 13, 2020 17:36
@rickharris rickharris mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@rickharris @tommoor @timc1