fix(completions): zsh and powershell completions #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
pd93 approved these changes Sep 18, 2024
Member
| @vmaerten Do you think it is worth doing a patch release for this? |
Member Author
| @pd93 As the "old" method still works well, I would say it can wait We also could remove this option (the one) in the website waiting for the new release (3.40). This way, our website will be up to date. But I am ok with releasing a patch! |
andreynering approved these changes Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1796
If fixes for powershell but also for zsh
Based on #1807 , and github cli (
echo "$(gh completion -s zsh)")I removed local that were not used.
I also checked for fish and bash, it works well.