Svace static analyzer fix #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| We are no longer accepting pull request or issues posted by bots or some github scanner, which comes without any comment, or discussion of any sort. Please reformulate your pull request. |
Signed-off-by: Artem Seleznev <seleznyov.artyom@gmail.com>
artemseleznev force-pushed the master branch from a558d5e to 571ab37 Compare | @fredbi, thanks for your feedback. I've updated the description and signed off my commit |
fredbi approved these changes Sep 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #208 +/- ## ========================================== + Coverage 91.42% 91.47% +0.05% ========================================== Files 23 23 Lines 3952 3952 ========================================== + Hits 3613 3615 +2 + Misses 255 254 -1 + Partials 84 83 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Svace static analyzer (https://www.ispras.ru/en/technologies/svace/) flagged this code as suspicious: it could lead to a panic (nil pointer dereference) because s.Schema might be nil.
I see a s.Schema != nil check on line 149, which suggests that a nil schema is a valid possible state that isn't fully handled here