driver: context support #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Close instead of SetTimeout hack implement more interfaces, with assertions
serprex commented Feb 21, 2025
serprex added a commit to PeerDB-io/peerdb that referenced this pull request Feb 25, 2025
based on go-mysql-org/go-mysql#997 without having to switch to `database/sql`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
database/sqlQueryContextfalls back to checking if context is done before callingQuery, so query does not get cancelled when context is cancelled once execution startsdriver.Queryer is deprecated
Unfortunately supporting this on top of net.Conn requires a goroutine. But that goroutine can be shared across lifetime of connection since connection doesn't need to be threadsafe
To cancel ongoing Read/Write the connection is closed when context finishes
At the end of the function active context is switched to
context.Background(). Some error handling could be implemented around receiving non-background context when active context is a non-background context, as that implies thread safety has been violated