replication: Make ServerVersion a proper string #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The ServerVersion is a slice of 50 bytes. If the ServerVersion was "9.1.0" then the rest of they bytes would be 0x0. This caused the printout of the FormatDescriptionEvent in go-mysqlbinlog to look weird. Before: ``` === FormatDescriptionEvent === Date: 2024-10-24 14:42:04 Log position: 127 Event size: 123 Version: 4 Server version: 9.1.0^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@ Checksum algorithm: 1 ``` After: ``` === FormatDescriptionEvent === Date: 2024-10-24 14:42:04 Log position: 127 Event size: 123 Version: 4 Server version: 9.1.0 Checksum algorithm: 1 ```
lance6716 approved these changes Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The ServerVersion is a slice of 50 bytes. If the ServerVersion was "9.1.0" then the rest of they bytes would be 0x0.
This caused the printout of the FormatDescriptionEvent in go-mysqlbinlog to look weird.
Before:
After: