Skip to content

Switch zstd library to allow build on arm64 and amd64 #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2023
Merged

Switch zstd library to allow build on arm64 and amd64 #801

merged 1 commit into from
Jun 19, 2023

Conversation

@dveeden
Copy link
Collaborator

@dveeden dveeden commented Jun 18, 2023 •
edited
Loading

Closes #799

  • Allow build on ARM64
  • Switch from github.com/DataDog/zstd to github.com/klauspost/compress
  • Change go version from 1.16 to 1.18 in go.mod
  • Add basic CI tests for building for various OS and Arch combinations

Note that this basically removes support for older versions of Go (1.17 and 1.16)
@dveeden dveeden requested review from atercattus and lance6716 June 18, 2023 15:54
@dveeden dveeden force-pushed the arm64 branch 2 times, most recently from ecb28a1 to 8eef251 Compare June 18, 2023 16:03
@dveeden dveeden marked this pull request as ready for review June 18, 2023 16:04
@dveeden dveeden mentioned this pull request Jun 18, 2023
Closed
@lance6716 lance6716 merged commit 98692a4 into go-mysql-org:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dveeden @lance6716