Skip to content

change valueExpr to pingcap test_driver implements #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

change valueExpr to pingcap test_driver implements #755

wants to merge 0 commits into from

Conversation

@BLAZZ
Copy link
Contributor

@BLAZZ BLAZZ commented Dec 13, 2022

fix valueExpr not work call Restore(ctx *format.RestoreCtx) #754
lance6716
lance6716 reviewed Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is very complicated 😂 can you refer to where did you copy the code in comment, and add a test for it?
@BLAZZ
Copy link
Contributor Author

BLAZZ commented Dec 14, 2022

those code is from https://github.com/pingcap/parser/tree/master/test_driver
@BLAZZ BLAZZ closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@BLAZZ @lance6716