handle columnIdx out range data size #689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bingoohuang commented Apr 2, 2022
bingoohuang commented - handle columnIdx out range data size
- refactor code to avoid type cast
lance6716 reviewed Apr 2, 2022
canal/sync.go Outdated
| func (c *Canal) handleRowsEvent(e *replication.BinlogEvent) error { | ||
| ev := e.Event.(*replication.RowsEvent) | ||
| | ||
| func (c *Canal) handleRowsEvent(e *replication.BinlogEvent, ev *replication.RowsEvent) error { |
There was a problem hiding this comment.
we can change the parameter to (*EventHeader, *RowsEvent), that's not duplicated
There was a problem hiding this comment.
As your suggestion, the parameters have been updated.
| Is there perhaps a unit test for this piece of code that can be adjusted to test the specific issue @bingoohuang ran into? To prevent future regression? |
| @bingoohuang @lance6716 what's the next step for this PR? |
| replaced by #856 , because that PR has unit tests 😄 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.