fix bug when cardinality is nil #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
change field to column
| @holys PTAL |
siddontang reviewed Oct 24, 2017
schema/schema.go Outdated
| } | ||
| | ||
| currentIndex.AddColumn(colName, cardinality) | ||
| c, ok := cardinality.(int) |
There was a problem hiding this comment.
can we meet other types (not just int) here?
| Some suggestions:
|
| @NearTan Ok |
siddontang reviewed Oct 24, 2017
schema/schema.go Outdated
| currentIndex.AddColumn(colName, c) | ||
| switch cardinality := cardinality.(type) { | ||
| case int, int8, int16, int32, int64, uint8, uint16, uint32, uint64: |
| LGTM. |
siddontang reviewed Oct 24, 2017
schema/schema.go Outdated
| currentIndex.AddColumn(colName, uint64(c)) | ||
| case int64: | ||
| currentIndex.AddColumn(colName, uint64(c)) | ||
| case uint8: |
IANTHEREAL reviewed Oct 24, 2017
schema/schema.go Outdated
| case uint32: | ||
| currentIndex.AddColumn(colName, uint64(c)) | ||
| case uint64: | ||
| currentIndex.AddColumn(colName, uint64(c)) |
| LGTM |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
it is fix for issue #173