Expose public method for syncer's next position #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
siddontang reviewed Sep 13, 2017
replication/binlogsyncer.go Outdated
| } | ||
| | ||
| // GetNextPosition returns the next position of the syncer | ||
| func (b *BinlogSyncer) GetNextPosition() *Position { |
There was a problem hiding this comment.
I prefer return copy Position to avoid outer changing the nextPos.
| Thank you quick reply! I have updated the function signature to return an instance of |
| LGTM |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For my project, it is useful to have a reference to the next position that the syncer will read from :)