Skip to content

fix a bug when set gtid set in query event and xid event #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Aug 11, 2017
Merged

fix a bug when set gtid set in query event and xid event #155

Changes from 40 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
cbade51
add function of get term field's value by field name
Apr 8, 2017
1a3b997
change field to column
WangXiangUSTC Apr 9, 2017
06a1322
Update rows.go
WangXiangUSTC Apr 9, 2017
bbed0d6
Merge remote-tracking branch 'remotesrc/master'
Apr 19, 2017
525eb21
add function to set dump charset
Apr 19, 2017
fddc322
add set of charcter
Apr 26, 2017
10f2f26
add config of mysql charset
Apr 30, 2017
8f5f42f
Update canal.go
WangXiangUSTC Apr 30, 2017
568899f
Update config.go
WangXiangUSTC Apr 30, 2017
1c2b0a6
Update config.go
WangXiangUSTC May 1, 2017
d41eb60
remove comment
WangXiangUSTC May 4, 2017
c342f9c
Update dump_test.go
WangXiangUSTC May 4, 2017
acf0521
Update config.go
WangXiangUSTC May 4, 2017
1652936
remove unused code
WangXiangUSTC May 4, 2017
c7792f5
update go-mysql version
WangXiangUSTC May 5, 2017
f444682
merge from remote master
Jul 22, 2017
09168b9
fix a bug
WangXiangUSTC Jul 22, 2017
d90ee86
if use gtid sync, use gtid when retry
Jul 22, 2017
6582b7c
modify code
Jul 22, 2017
1e4c520
fix bug
Jul 23, 2017
011e9d0
fix bug
Jul 23, 2017
7a894fe
Update binlogsyncer.go
WangXiangUSTC Jul 23, 2017
489a5e9
Update config.go
WangXiangUSTC Jul 23, 2017
b646916
Update config.go
WangXiangUSTC Jul 23, 2017
ab8fee0
Update dump.go
WangXiangUSTC Jul 23, 2017
e5b7164
Update glide.lock
WangXiangUSTC Jul 23, 2017
89d8714
Update mariadb_gtid.go
WangXiangUSTC Jul 24, 2017
9d183be
change if else to switch
Jul 24, 2017
55f10a0
change updategtidset to update
Jul 27, 2017
eb4c160
add gtid set information in xid event
Jul 30, 2017
bddcc7f
merge remote src
Jul 30, 2017
ddd4ee6
Update binlogsyncer.go
WangXiangUSTC Jul 31, 2017
b3f2817
Update event.go
WangXiangUSTC Jul 31, 2017
b72a2bc
Merge remote-tracking branch 'remote_src/master'
Aug 1, 2017
c5d3464
add gtid set information in query event
Aug 1, 2017
5c0846d
add gtid set information in query event
Aug 1, 2017
4486811
Merge remote-tracking branch 'remote_src/master'
Aug 11, 2017
308f749
fix a bug when set gtid set in query event and xid event
Aug 11, 2017
6c8050e
test
WangXiangUSTC Aug 11, 2017
da4666a
Update binlogsyncer.go
WangXiangUSTC Aug 11, 2017
ee8c00d
define a function to get gset checkpoint
Aug 11, 2017
b95c759
format code
WangXiangUSTC Aug 11, 2017
f7b3b2c
Update binlogsyncer.go
WangXiangUSTC Aug 11, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions replication/binlogsyncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,9 +649,23 @@ func (b *BinlogSyncer) parseEvent(s *BinlogStreamer, data []byte) error {
return errors.Trace(err)
}
case *XIDEvent:
event.GSet = b.gset
if !b.useGTID {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we abstract a function to do it?
break
}
if b.cfg.Flavor != MariaDBFlavor {
event.GSet, _ = ParseGTIDSet(MySQLFlavor, b.gset.String())
} else {
event.GSet, _ = ParseGTIDSet(MariaDBFlavor, b.gset.String())
}
case *QueryEvent:
event.GSet = b.gset
if !b.useGTID {
break
}
if b.cfg.Flavor != MariaDBFlavor {
event.GSet, _ = ParseGTIDSet(MySQLFlavor, b.gset.String())
} else {
event.GSet, _ = ParseGTIDSet(MariaDBFlavor, b.gset.String())
}
}

needStop := false
Expand Down