Only check for semi-sync ack request if semi-sync is enabled for this connection #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… connection I think this is correct, since the docs[1] for enabling semi-sync indicate that not all slaves need to support it, even if the msater does. This does resolve the problem I sort-of-reported in go-mysql-org#13, which appears to be two bytes missing from the beginning of the packet at the time the event is parsed. [1]: https://dev.mysql.com/doc/refman/5.5/en/replication-semisync-installation.html
siddontang added a commit that referenced this pull request Jun 29, 2015
Only check for semi-sync ack request if semi-sync is enabled for this connection
| Thank you very much. @blalor |
| You’re welcome. I can’t really attest to the correctness of this approach, but it does work for me. :-) |
| Your are right. I didn't think the first two bytes may be the same as semi-sync head, my fault :-) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I think this is correct, since the docs1 for enabling semi-sync indicate that not all slaves need to support it, even if the msater does. This does resolve the problem I sort-of-reported in #13, which appears to be two bytes missing from the beginning of the packet at the time the event is parsed.