Skip to content

Improve unit tests around Hasresultset and WriteValue #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 9, 2025
Merged

Improve unit tests around Hasresultset and WriteValue #1006

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0462083
update server tests to use constructor convention from d02e79a
stgarrity Mar 5, 2025
ef77e5a
unit test the nil case of Hasresultset
stgarrity Mar 5, 2025
21883cd
unit test WriteValue for OK vs Resultset
stgarrity Mar 5, 2025
f98087c
handle nil result correctly, and test nil resultset correctly
stgarrity Mar 5, 2025
bc26bed
test brevity
stgarrity Mar 9, 2025
f7efb07
Merge branch 'master' into stg/server_missed_ok
stgarrity Mar 9, 2025
3791fba
Merge branch 'master' into stg/server_missed_ok
stgarrity Mar 9, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test brevity
  • Loading branch information
@stgarrity
stgarrity committed Mar 9, 2025
commit bc26bedf448230c1b0d0ad48d46340dd66288a0f
8 changes: 4 additions & 4 deletions mysql/result_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,25 @@ import (
func TestHasResultset_false(t *testing.T) {
r := NewResultReserveResultset(0)
b := r.HasResultset()
require.Equal(t, false, b)
require.False(t, b)
}

func TestHasResultset_true(t *testing.T) {
r := NewResultReserveResultset(1)
b := r.HasResultset()
require.Equal(t, true, b)
require.True(t, b)
}

// this shouldn't happen after d02e79a, but test just in case
func TestHasResultset_nilset(t *testing.T) {
r := NewResultReserveResultset(0)
r.Resultset = nil
b := r.HasResultset()
require.Equal(t, false, b)
require.False(t, b)
}

func TestHasResultset_nil(t *testing.T) {
var r *Result
b := r.HasResultset()
require.Equal(t, false, b)
require.False(t, b)
}