Skip to content

Add raw blob endpoint to get objects by SHA ID #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 18, 2018
Merged

Add raw blob endpoint to get objects by SHA ID #5334

merged 7 commits into from
Nov 18, 2018

Conversation

HoffmannP
Copy link
Contributor

feat: Add raw blob endpoint

Updating #4110, this PR enables fetching of raw SHA-ID'd objects via /:repo/:username/raw/blob/:sha1

It builds upon #132 (originally #121)

Signed-off-by: Berengar W. Lehr Berengar.Lehr@kompetenztest.de
clee and others added 3 commits November 14, 2018 08:16
@clee
Add raw blob endpoint
da76d52 
This should make it possible to download raw blobs directly from /:repo/:username/raw/blob/:sha1 URLs.
fix: Make it work
4a68eb9 
* As an SHA-ID is no path getRefNameFromPath can't be used to verify file specifying parameter * added relevant change in go-gitea/git #132 Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de>
Update Gopkg.lock
5c92f12 
Can't update all vendors due to errors Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de>
@codecov-io
Copy link

codecov-io commented Nov 14, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@4651ba0). Click here to learn what that means.
The diff coverage is 36.36%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #5334 +/- ## ========================================= Coverage ? 37.39% ========================================= Files ? 312 Lines ? 46436 Branches ? 0 ========================================= Hits ? 17367 Misses ? 26583 Partials ? 2486
Impacted Files Coverage Δ
routers/routes/routes.go 85.47% <100%> (ø)
routers/repo/download.go 48.14% <16.66%> (ø)
modules/context/repo.go 59.8% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4651ba0...e2bc14e. Read the comment docs.
@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2018
@lafriks lafriks added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/changelog Adds the changelog for a new Gitea version labels Nov 14, 2018
@lafriks lafriks changed the title Blob api Add raw blob endpoint to get objects by SHA ID Nov 14, 2018
@lunny
Copy link
Member

lunny commented Nov 14, 2018

@HoffmannP could you add some tests?
@techknowlogick techknowlogick added this to the 1.7.0 milestone Nov 14, 2018
techknowlogick
techknowlogick reviewed Nov 14, 2018
View reviewed changes
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 18, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 18, 2018
@techknowlogick techknowlogick merged commit e08c7e5 into go-gitea:master Nov 18, 2018
@lafriks lafriks mentioned this pull request Nov 18, 2018
Closed
@HoffmannP HoffmannP deleted the blob_api branch November 18, 2018 21:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

8 participants

@HoffmannP @codecov-io @lunny @techknowlogick @lafriks @bkcsoft @delvh @clee