Fix column droping for MySQL that need a new session for the new transaction #4459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
back2root force-pushed the fix/mysql_dropping_columns branch from f448a27 to a4a7dd0 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #4459 +/- ## ======================================= Coverage 20.08% 20.08% ======================================= Files 155 155 Lines 31099 31099 ======================================= Hits 6245 6245 Misses 23898 23898 Partials 956 956Continue to review full report at Codecov.
|
bkcsoft added the lgtm/need 2 
| This PR workarounds issue in xorm. I have updated xorm in #4473 that fixes these migrations without changing actual migration code |
| @back2root please confirm #4473 fix your problem. |
| @lunny I tested with PostgreSQL and after updating xorm it fixed the issue |
| @back2root I'm closing PRs, reopen if really still needed |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Finally Fixes #4360
Through PR #4440 an issue within migration scripts was introduced if running gitea with MySQL as Database.
This PR completely closes the database session and reopenes a new one to circumvent this issue. There may be a more performant solution. However, as this is only done once this solution should be sufficient.