Skip to content

Conversation

michaelkuhn
Copy link
Contributor

Backport of #3781

num_watches was used where num_stars should have been used.
@michaelkuhn michaelkuhn changed the base branch from master to release/v1.4 April 10, 2018 12:51
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 10, 2018
@techknowlogick
Copy link
Member

LGTM.

CI fail seems unrelated.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2018
@lunny lunny added the type/bug label Apr 11, 2018
@lunny lunny added this to the 1.4.1 milestone Apr 11, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v1.4@2ec85e0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@ ## release/v1.4 #3783 +/- ## =============================================== Coverage ? 22.61% =============================================== Files ? 117 Lines ? 24374 Branches ? 0 =============================================== Hits ? 5513 Misses ? 18011 Partials ? 850
Impacted Files Coverage Δ
models/user.go 23.82% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec85e0...0d3df05. Read the comment docs.

@lunny lunny merged commit 31c0a33 into go-gitea:release/v1.4 Apr 11, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

7 participants