Correctly check http git access rights for reverse proxy authorized users #3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lafriks added topic/security 
Codecov Report
@@ Coverage Diff @@ ## master #3721 +/- ## ======================================= Coverage 35.76% 35.76% ======================================= Files 289 289 Lines 41604 41604 ======================================= Hits 14879 14879 - Misses 24527 24528 +1 + Partials 2198 2197 -1
Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 
| hi, this it's a fix or its only a compatibility feature? and when will going to be backported to 1.4 branch? |
| @mckaygerhard it is bugfix and will be backported to 1.4 branch as soon other maintainers review&approve this PR |
Bwko approved these changes Mar 26, 2018
tboerger added lgtm/need 1 | only one more.. lgtm |
jonasfranz approved these changes Mar 28, 2018
tboerger added lgtm/done 
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Mar 30, 2018
lafriks added a commit that referenced this pull request Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes reverse proxy authorized users for access rights to git repositories when accessing from git client.
Review changes with
?w=1to easier see actual changes :)