Refactor and simplify redirect to url #3674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lafriks added type/refactoring 
Codecov Report
@@ Coverage Diff @@ ## master #3674 +/- ## ========================================== - Coverage 35.87% 35.87% -0.01% ========================================== Files 287 287 Lines 41362 41359 -3 ========================================== - Hits 14840 14837 -3 + Misses 24336 24334 -2 - Partials 2186 2188 +2
Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 
Bwko approved these changes Mar 15, 2018
tboerger added lgtm/need 1 
bkcsoft approved these changes Mar 15, 2018
tboerger added lgtm/done bkcsoft reviewed Mar 15, 2018
| } | ||
| | ||
| u, err := url.Parse(loc) | ||
| if err != nil || (u.Scheme != "" && !strings.HasPrefix(strings.ToLower(loc), strings.ToLower(setting.AppURL))) { |
There was a problem hiding this comment.
This will probably break someones setup, but it's slightly more secure 🤷♂️
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Mar 15, 2018
lunny pushed a commit that referenced this pull request Mar 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refactor and simplify redirect to url, also improve checking url for errors