Remove undocumented support of signing key in the repository git configuration file #36143
+133 −128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GiteaBot added the lgtm/need 2 
github-actions bot added modifies/api 
lunny added the type/refactoring 
silverwind approved these changes Dec 13, 2025
GiteaBot added lgtm/need 1 
wxiaoguang changed the title 
delvh approved these changes Dec 14, 2025
GiteaBot added lgtm/done 
Co-authored-by: delvh <dev.lh@web.de> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added the reviewed/wait-merge GiteaBot removed the reviewed/wait-merge zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 15, 2025
* giteaofficial/main: Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143) Enable gocheckcompilerdirectives linter (go-gitea#36156) Fix code highlighting on blame page (go-gitea#36157) Check user visibility when redirecting to a renamed user (go-gitea#36148) Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149) Refactor `FileTreeItem` type (go-gitea#36137) Fix various bugs (go-gitea#36139) Fix issue close timeline icon (go-gitea#36138) Add permissions to`files-changed` jobs (go-gitea#36142) Add explicit permissions to all actions workflows (go-gitea#36140) Bump `actions/checkout` to v6 (go-gitea#36136) Hide RSS icon when viewing a file not under a branch (go-gitea#36135) Fix SVG size calulation, only use `style` attribute (go-gitea#36133) Add sorting/filtering to admin user search API endpoint (go-gitea#36112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per-repository signing keys have never been officially supported, as they would require users to modify the repository’s config file.
At this point, it is clear that only global signing keys (GPG or SSH) should be allowed. If we want to introduce per-repository signing keys in the future, it will require a complete design proposal.
The endpoint will not be removed for repository special signing key, but it will reference the global signing key.