Remove padding override on .ui .sha.label #35864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GiteaBot added the lgtm/need 2 
delvh approved these changes Nov 5, 2025
GiteaBot added lgtm/need 1 
wxiaoguang approved these changes Nov 5, 2025
GiteaBot added lgtm/done 
silverwind added the reviewed/wait-merge GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 6, 2025
Since upgrading to v1.25, I noticed the SHA labels have slightly different padding than before. I can't pinpoint exactly which change it was. Fix it by removing the padding override on `.ui .sha.label` and make the one on`.ui.label` (`2px 6px`) take effect which matches 1.24 rendering. Before: <img width="135" height="172" alt="image" src="https://github.com/user-attachments/assets/2781a854-be08-4a11-bde0-d3699b2b7454" /> After: <img width="139" height="162" alt="image" src="https://github.com/user-attachments/assets/5c864fa3-c1f9-4452-ae58-5411dd445865" />
GiteaBot added backport/done zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 6, 2025
* giteaofficial/main: Remove padding override on `.ui .sha.label` (go-gitea#35864) fix(api/repo/contents): set the dates to now when not specified by the caller (go-gitea#35861) Remove `fix` Make targets (go-gitea#35868) Refactor ls-tree and git path related problems (go-gitea#35858) Fix pull description code label background (go-gitea#35865) Make ACME email optional (go-gitea#35849) Remove wrong code (go-gitea#35846) Fix Arch repo pacman.conf snippet (go-gitea#35825) Port away from `flake-utils` (go-gitea#35675) Update golangci-lint to v2.6.0 (go-gitea#35801) Add a doctor command to fix inconsistent run status (go-gitea#35840) Fix viewed files number is not right if not all files loaded (go-gitea#35821) Fix incorrect pull request counter (go-gitea#35819) Fix a number of `strictNullChecks`-related issues (go-gitea#35795) ignore .worktrees as a "special folder" (go-gitea#35835) upgrade go mail to 0.7.2 and fix the bug (go-gitea#35833)
silverwind added a commit that referenced this pull request Nov 6, 2025
Backport #35864 by @silverwind Since upgrading to v1.25, I noticed the SHA labels have slightly different padding than before. I can't pinpoint exactly which change it was. Fix it by removing the padding override on `.ui .sha.label` and make the one on`.ui.label` (`2px 6px`) take effect which matches 1.24 rendering. Before: <img width="135" height="172" alt="image" src="https://github.com/user-attachments/assets/2781a854-be08-4a11-bde0-d3699b2b7454" /> After: <img width="139" height="162" alt="image" src="https://github.com/user-attachments/assets/5c864fa3-c1f9-4452-ae58-5411dd445865" /> Co-authored-by: silverwind <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since upgrading to v1.25, I noticed the SHA labels have slightly different padding than before. I can't pinpoint exactly which change it was. Fix it by removing the padding override on
.ui .sha.labeland make the one on.ui.label(2px 6px) take effect which matches 1.24 rendering.Before:
After: