Fix escaping changed title in comments (#3530) #3535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Fix escaping of wiki page titile Signed-off-by: Lauris Bukšis-Haberkorns <lauris@nix.lv>
lafriks added the topic/security 
Bwko approved these changes Feb 18, 2018
tboerger added the lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 23, 2025
When mentioning a user, the markup post-processor did not handle the case where the mentioned user did not exist well: it tried to skip to the next node, which in turn, ended up skipping the rest of the line. To fix this, lets skip just the mentioned, but non-existing user, and continue processing the current node from there. Fixes go-gitea#3535. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu> (cherry picked from commit 9a01062)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport #3530