Skip to content

Fixes missing avatars in offline mode #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2018
Merged

Fixes missing avatars in offline mode #3471

merged 2 commits into from
Feb 8, 2018

Conversation

sdwolfz
Copy link
Contributor

@sdwolfz sdwolfz commented Feb 7, 2018

Fixes #3464.

I got the idea for this fix from here.
Aparently in offline mode the avatar filename is already set before it is generated and this line overwrote it every time.
@sdwolfz
Fixes missing avatars in offline mode
c2ea75a 
Signed-off-by: Codruț Constantin Gușoi <codrut.gusoi@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 7, 2018 •
edited
Loading

Codecov Report

Merging #3471 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3471 +/- ## ========================================== - Coverage 35.69% 35.68% -0.01%  ========================================== Files 281 281 Lines 40706 40708 +2 ========================================== - Hits 14528 14527 -1  - Misses 24028 24030 +2  - Partials 2150 2151 +1
Impacted Files Coverage Δ
models/user.go 39.56% <100%> (+0.13%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9720f90...a86c295. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 7, 2018
@lafriks lafriks added this to the 1.5.0 milestone Feb 8, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2018
@bkcsoft bkcsoft merged commit 011f128 into go-gitea:master Feb 8, 2018
@lafriks
Copy link
Member

lafriks commented Feb 8, 2018

@sdwolfz please backport commit 011f128 to branch release/v1.4
@sdwolfz sdwolfz deleted the fix/missing-avatar branch February 8, 2018 21:05
@sdwolfz sdwolfz mentioned this pull request Feb 8, 2018
Merged
lafriks pushed a commit that referenced this pull request Feb 14, 2018
@sdwolfz @lafriks
Fixes missing avatars in offline mode (#3471) (#3477)
1c3d712 
Signed-off-by: Codruț Constantin Gușoi <codrut.gusoi@gmail.com>
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 18, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

6 participants

@sdwolfz @codecov-io @lafriks @Bwko @tboerger @bkcsoft