Skip to content

Fix go-get content type #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2018
Merged

Fix go-get content type #3426

merged 2 commits into from
Jan 29, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 29, 2018 •
edited
Loading

As title to finally fix godoc support, forgotten commit for #3423
@lafriks lafriks added this to the 1.4.0 milestone Jan 29, 2018
@codecov-io
Copy link

codecov-io commented Jan 29, 2018 •
edited
Loading

Codecov Report

Merging #3426 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3426 +/- ## ========================================== - Coverage 35.65% 35.59% -0.06%  ========================================== Files 281 281 Lines 40591 40593 +2 ========================================== - Hits 14471 14451 -20  - Misses 23981 24001 +20  - Partials 2139 2141 +2
Impacted Files Coverage Δ
modules/context/context.go 46.35% <0%> (-0.63%) ⬇️
models/repo_indexer.go 41.15% <0%> (-7.53%) ⬇️
modules/indexer/indexer.go 70% <0%> (-7.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af8197...7be9670. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2018
@thehowl
Copy link
Contributor

thehowl commented Jan 29, 2018

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2018
@lafriks lafriks merged commit aef3007 into go-gitea:master Jan 29, 2018
@lafriks lafriks deleted the fix/godoc_goget branch January 29, 2018 17:50
bkcsoft
bkcsoft reviewed Feb 10, 2018
View reviewed changes
modules/context/context.go
c.PlainText(http.StatusOK, []byte(com.Expand(`<!doctype html>
c.Header().Set("Content-Type", "text/html")
c.WriteHeader(http.StatusOK)
c.Write([]byte(com.Expand(`<!doctype html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be moved to a template instead 😂
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

6 participants

@lafriks @codecov-io @thehowl @sapk @bkcsoft @tboerger