Skip to content

Fix SQL type error for webhooks #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2018
Merged

Fix SQL type error for webhooks #3424

merged 2 commits into from
Jan 29, 2018

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jan 28, 2018 •
edited
Loading

HookQueue contains strings, and we forget to convert the string to an int. As a result, webhooks are not properly fired (at least for MySQL, not sure about other RDBMSs)
@codecov-io
Copy link

codecov-io commented Jan 28, 2018 •
edited
Loading

Codecov Report

Merging #3424 into master will decrease coverage by 0.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3424 +/- ## ========================================= - Coverage 35.61% 35.6% -0.02%  ========================================= Files 281 281 Lines 40589 40593 +4 ========================================= - Hits 14457 14452 -5  - Misses 23995 24001 +6  - Partials 2137 2140 +3
Impacted Files Coverage Δ
models/webhook.go 67.02% <62.5%> (-0.46%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo.go 42.98% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e189b06...3fed3c0. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 28, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2018
@lafriks lafriks merged commit 3968c11 into go-gitea:master Jan 29, 2018
@ethantkoenig ethantkoenig mentioned this pull request Jan 29, 2018
Merged
@ethantkoenig ethantkoenig deleted the fix/hook branch January 29, 2018 04:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

5 participants

@ethantkoenig @codecov-io @techknowlogick @lafriks @tboerger