Skip to content

Fix mirror bug (#33597) #33607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

Fix mirror bug (#33597) #33607

merged 1 commit into from
Feb 16, 2025

Conversation

GiteaBot
Copy link
Collaborator

Backport #33597 by @ericLemanissier

follows-up be4e961

This is the same modification as be4e961 but for force-pushes.
It is needed, because git fetch reveals force pushes for github mirrors:

$ git fetch --tags origin remote: Enumerating objects: 22, done. remote: Counting objects: 100% (22/22), done. remote: Compressing objects: 100% (4/4), done. remote: Total 9 (delta 5), reused 8 (delta 5), pack-reused 0 (from 0) Unpacking objects: 100% (9/9), 1.70 KiB | 12.00 KiB/s, done. From https://github.com/conan-io/conan-center-index 729f0f1b8f..48184eddeb refs/pull/26595/head -> refs/pull/26595/head + 0c31ab60a3...1283cca9e7 refs/pull/26595/merge -> refs/pull/26595/merge (forced update)

Fix #33200

PS: I did not test the modification, but it is the exact same change as the last hunk in https://github.com/go-gitea/gitea/pull/33224/files#diff-bb5cdb90db0f0e7f6716c0e6d0b9cbb67f08d82052b03ab3a7b5e23a1d76aed7 , just moved to the previous case of the switch

I think it could and should be back-ported to 1.23
@ericLemanissier @GiteaBot
Fix mirror bug (go-gitea#33597)
7af4071 
follows-up be4e961 Fix go-gitea#33200 --------- Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/bug labels Feb 15, 2025
@GiteaBot GiteaBot requested review from delvh and lunny February 15, 2025 23:16
@GiteaBot GiteaBot added this to the 1.23.4 milestone Feb 15, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2025
@lunny lunny merged commit 99545ae into go-gitea:release/v1.23 Feb 16, 2025
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

4 participants

@GiteaBot @lunny @hiifong @ericLemanissier