Move some Actions related functions from routers to services #33280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GiteaBot added the lgtm/need 2 
github-actions bot added modifies/api 
wxiaoguang reviewed Jan 15, 2025
lunny reviewed Jan 15, 2025
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny reviewed Jan 15, 2025
lunny reviewed Jan 15, 2025
lunny reviewed Jan 15, 2025
lunny reviewed Jan 15, 2025
lunny reviewed Jan 15, 2025
| Can we have a test for GenerateGiteaContext |
Add a test in fdae294 |
lunny approved these changes Jan 15, 2025
GiteaBot added lgtm/need 1 wxiaoguang approved these changes Jan 15, 2025
GiteaBot added lgtm/done 
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 16, 2025
* giteaofficial/main: Only allow admins to rename default/protected branches (go-gitea#33276) Enable Typescript `noImplicitThis` (go-gitea#33250) Prepare for support performance trace (go-gitea#33286) Fix closed dependency title (go-gitea#33285) Move some Actions related functions from `routers` to `services` (go-gitea#33280) Fix incorrect TagName/BranchName usages (go-gitea#33279)
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 26, 2025
…gitea#33280) Move the main logic of `generateTaskContext` and `findTaskNeeds` to the `services` layer. This is a part of go-gitea#32751, since we need the git context and `needs` to parse the concurrency expressions. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit d0962ce) Conflicts: routers/api/actions/runner/main_test.go routers/api/actions/runner/utils.go services/actions/context_test.go services/actions/init_test.go tests/integration/actions_job_test.go simple conflicts related to ref_type": string(refName.RefType()), // string, The type of ref that triggered the workflow run. Valid values are branch or tag. Use env GITEA_RUNNER_REGISTRATION_TOKEN as global runner token (go-gitea#32946)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Move the main logic of
generateTaskContextandfindTaskNeedsto theserviceslayer.This is a part of #32751, since we need the git context and
needsto parse the concurrency expressions.