Skip to content

Fix bug when a user delete but assigned on issue #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2018
Merged

Fix bug when a user delete but assigned on issue #3318

merged 1 commit into from
Jan 7, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 7, 2018

wiil fix #3314
@lunny lunny added this to the 1.4.0 milestone Jan 7, 2018
@lunny lunny force-pushed the lunny/fix_comment_user_del branch from fdd8ff7 to cc2a128 Compare January 7, 2018 02:25
@codecov-io
Copy link

codecov-io commented Jan 7, 2018 •
edited
Loading

Codecov Report

Merging #3318 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3318 +/- ## ========================================== - Coverage 35.09% 35.07% -0.02%  ========================================== Files 279 279 Lines 40522 40526 +4 ========================================== - Hits 14220 14215 -5  - Misses 24201 24209 +8  - Partials 2101 2102 +1
Impacted Files Coverage Δ
models/issue_comment.go 52.65% <0%> (-0.5%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4002328...cc2a128. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 7, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2018
@lafriks lafriks merged commit 835b890 into go-gitea:master Jan 7, 2018
@lunny lunny deleted the lunny/fix_comment_user_del branch January 7, 2018 14:09
bkcsoft
bkcsoft reviewed Jan 8, 2018
View reviewed changes
models/issue_comment.go
if !IsErrUserNotExist(err) {
return err
}
c.OldAssignee = NewGhostUser()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not unassign the issue? 🤔
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is unassigned afaik, this is just comment that issue was assigned to user
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

6 participants

@lunny @codecov-io @appleboy @lafriks @bkcsoft @tboerger