Skip to content

Use project's redirect url instead of composing url #33058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 31, 2024
Merged

Use project's redirect url instead of composing url #33058

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1aacf76
Use project's redirect url instead of composing url
lunny Dec 31, 2024
d4a8dd7
Add some comments
lunny Dec 31, 2024
a56ee15
improve the code
lunny Dec 31, 2024
1979bd7
Merge branch 'main' into lunny/fix_create_issue_project
lunny Dec 31, 2024
a381d78
Remove comment
lunny Dec 31, 2024
1b482fa
Merge branch 'main' into lunny/fix_create_issue_project
wxiaoguang Dec 31, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions routers/web/repo/issue_new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,17 @@ func NewIssuePost(ctx *context.Context) {

log.Trace("Issue created: %d/%d", repo.ID, issue.ID)
if ctx.FormString("redirect_after_creation") == "project" && projectID > 0 {
ctx.JSONRedirect(ctx.Repo.RepoLink + "/projects/" + strconv.FormatInt(projectID, 10))
} else {
ctx.JSONRedirect(issue.Link())
project, err := project_model.GetProjectByID(ctx, projectID)
if err == nil {
// to reduce load the content from database again, we just set the owner/repo here
if project.Type == project_model.TypeOrganization {
project.Owner = ctx.Repo.Owner
} else {
project.Repo = ctx.Repo.Repository
}
ctx.JSONRedirect(project.Link(ctx))
return
}
}
ctx.JSONRedirect(issue.Link())
}
Loading