Skip to content

Use issue number/index instead of id for API URL. Fix #3297 #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2018
Merged

Use issue number/index instead of id for API URL. Fix #3297 #3298

merged 2 commits into from
Jan 4, 2018

Conversation

AlbertoGP
Copy link
Contributor

@AlbertoGP AlbertoGP commented Jan 3, 2018 •
edited
Loading

No description provided.

@AlbertoGP
Use issue number/index instead of id for API URL.
f546b86 
Using the API calls, the issue objects retrieved by /repos/{owner}/{repo}/issues contains the wrong value in the "url" field: it uses the "id" value instead of the "number" value. For instance, in a new repo in try.gitea.io with just one issue: [{ "id": 896, "url": "https://try.gitea.io/api/v1/repos/AlbertoGP/uno/issues/896", "number": 1, ... }] The given URL does not work, but if you replace the "896" by "1" it does.
@codecov-io
Copy link

Codecov Report

Merging #3298 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3298 +/- ## ========================================== - Coverage 34.81% 34.62% -0.19%  ========================================== Files 277 277 Lines 40271 40271 ========================================== - Hits 14021 13945 -76  - Misses 24189 24282 +93  + Partials 2061 2044 -17
Impacted Files Coverage Δ
models/issue.go 44.43% <100%> (ø) ⬆️
modules/lfs/content_store.go 7.81% <0%> (-35.94%) ⬇️
modules/lfs/server.go 20.68% <0%> (-14.33%) ⬇️
models/lfs.go 26.08% <0%> (-2.18%) ⬇️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5057c6b...f546b86. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2018
@lafriks lafriks added this to the 1.4.0 milestone Jan 3, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 3, 2018
@lunny
Copy link
Member

lunny commented Jan 4, 2018

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 4, 2018
@lunny lunny added the modifies/api This PR adds API routes or modifies them label Jan 4, 2018
@lunny
Copy link
Member

lunny commented Jan 4, 2018

will fix #3297
@lunny lunny merged commit 30fb81c into go-gitea:master Jan 4, 2018
@lunny lunny mentioned this pull request Jan 4, 2018
Closed
7 tasks
@ethantkoenig ethantkoenig mentioned this pull request Jan 4, 2018
Merged
@lunny lunny mentioned this pull request Jan 5, 2018
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

5 participants

@AlbertoGP @codecov-io @lunny @lafriks @tboerger