Fix always-on SSL Mode checkbox in admin page

[strk]

Closes #3207

Needs backport to 1.3 branch too

[strk]

Actually the supported values are:

only "require" (default), "verify-full", "verify-ca", and "disable" supported

So a checkbox is really not a good idea!

[ethantkoenig]

Since this is a UI change (albeit a minor one), could you please include before/after screenshots?

[codecov-io]

Codecov Report

Merging #3208 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #3208 +/- ## ========================================== - Coverage 34.87% 34.69% -0.18%  ========================================== Files 277 277 Lines 39980 39980 ========================================== - Hits 13943 13873 -70  - Misses 24020 24110 +90  + Partials 2017 1997 -20

Impacted Files	Coverage Δ
modules/lfs/content_store.go	7.81% <0%> (-35.94%)	⬇️
modules/lfs/server.go	20.68% <0%> (-14.33%)	⬇️
models/lfs.go	26.08% <0%> (-2.18%)	⬇️
models/repo.go	41.47% <0%> (+0.18%)	⬆️
models/repo_indexer.go	51.94% <0%> (+0.97%)	⬆️
modules/process/manager.go	81.15% <0%> (+4.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update befa744...d906521. Read the comment docs.

[lafriks]

LGTM

[strk]

Screenshot is not much interesting, imagine a string like the one you get for Path instead of a checkbox. It takes too much time for me to create the screenshot(s) and blur out the passwords etc. And you should review the code, not trust screenshots :)

[strk]

Found the time: this is after:

[ethantkoenig]

LGTM @strk with hindsight, screenshot was probably not necessary, my apologies