Remove SHA1 for support for ssh rsa signing #31857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
https://github.com/go-fed/httpsig seems to be unmaintained. Switch to github.com/42wim/httpsig which has removed deprecated crypto and default sha256 signing for ssh rsa. No impact for those that use ed25519 ssh certificates. This is a breaking change for: - gitea.com/gitea/tea (go-sdk) - I'll be sending a PR there too - activitypub using deprecated crypto (is this actually used?)
GiteaBot added the lgtm/need 2 
github-actions bot added modifies/api 
| Thanks @42wim, could you run |
lunny added the pr/breaking 
| Here is the diff from that fork: go-fed/httpsig@master...42wim:httpsig:master |
techknowlogick approved these changes Sep 7, 2024
GiteaBot added lgtm/need 1 
delvh approved these changes Sep 7, 2024
GiteaBot added lgtm/done lunny added the reviewed/wait-merge 
GiteaBot removed the reviewed/wait-merge zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 9, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores [skip ci] Updated translations via Crowdin Remove SHA1 for support for ssh rsa signing (go-gitea#31857) Upgrade cache to v0.2.1 (go-gitea#32003) Add automatic light/dark option for the colorblind theme (go-gitea#31997) [skip ci] Updated translations via Crowdin Use global lock instead of NewExclusivePool to allow distributed lock between multiple Gitea instances (go-gitea#31813) Use forum.gitea.com instead of old URL (go-gitea#31989) Distinguish official vs non-official reviews, add tool tips, and upgr… (go-gitea#31924)
wxiaoguang removed the pr/breaking Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://github.com/go-fed/httpsig seems to be unmaintained.
Switch to github.com/42wim/httpsig which has removed deprecated crypto and default sha256 signing for ssh rsa.
No impact for those that use ed25519 ssh certificates.
This is a breaking change for: