Skip to content

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 2, 2017

Out of the 3469 lines of code in the .less files, 2004 were indented with spaces while 1465 were indented with tabs. I converted all tab indendation to 4 spaces as specified in .editorconfig using this command:

find . ! -type d -exec bash -c 'expand -t 4 "$0" > /tmp/e && mv /tmp/e "$0"' {} \; 

If we want to use tabs in these files, I'd be open to that too, but it should be consistent and in .editorconfig.

@codecov-io
Copy link

codecov-io commented Dec 2, 2017

Codecov Report

Merging #3064 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3064 +/- ## ========================================== + Coverage 33.43% 33.44% +<.01%  ========================================== Files 270 270 Lines 39553 39553 ========================================== + Hits 13226 13229 +3  + Misses 24441 24439 -2  + Partials 1886 1885 -1
Impacted Files Coverage Δ
modules/avatar/avatar.go 100% <0%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9db60e...8fb5fa8. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2017
@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

Need to resolve conflicts

@lafriks
Copy link
Member

lafriks commented Dec 2, 2017

But otherwise LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2017
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 2, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 2, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2017
@silverwind
Copy link
Member Author

Rebased.

@lafriks lafriks merged commit d44aa83 into go-gitea:master Dec 2, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

5 participants