Skip to content

Dashboard: Fix line height problem in issue titles #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2017
Merged

Dashboard: Fix line height problem in issue titles #3054

merged 1 commit into from
Dec 2, 2017

Conversation

silverwind
Copy link
Member

Found a minor issue on the dashboard with issue titles where the lower end of a g could be cut off slightly. I fixed it by removing a seemingly unnecessary line-height definition.

Before

screen shot 2017-12-01 at 17 33 28

After

screen shot 2017-12-01 at 17 43 42
@codecov-io
Copy link

Codecov Report

Merging #3054 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3054 +/- ## ========================================== - Coverage 33.38% 33.35% -0.04%  ========================================== Files 270 270 Lines 39566 39566 ========================================== - Hits 13211 13198 -13  - Misses 24466 24482 +16  + Partials 1889 1886 -3
Impacted Files Coverage Δ
models/repo_indexer.go 45.54% <0%> (-6.44%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-2.61%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57edc31...723585e. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 1, 2017
@sapk
Copy link
Member

sapk commented Dec 1, 2017

LGTM
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 1, 2017
@ethantkoenig
Copy link
Member

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 2, 2017
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Dec 2, 2017
@lunny lunny merged commit d8d38ed into go-gitea:master Dec 2, 2017
@silverwind silverwind deleted the dashboard-issue-text branch December 2, 2017 08:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

7 participants

@silverwind @codecov-io @sapk @ethantkoenig @appleboy @lunny @tboerger