Skip to content

Default log level to Info without hardcoding it in installer #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

Default log level to Info without hardcoding it in installer #3041

merged 1 commit into from
Dec 1, 2017

Conversation

0rzech
Copy link
Contributor

@0rzech 0rzech commented Dec 1, 2017 •
edited
Loading

Partially solves #2984.
@codecov-io
Copy link

Codecov Report

Merging #3041 into master will decrease coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3041 +/- ## ========================================== - Coverage 33.38% 33.34% -0.04%  ========================================== Files 270 270 Lines 39570 39566 -4 ========================================== - Hits 13209 13195 -14  - Misses 24478 24484 +6  - Partials 1883 1887 +4
Impacted Files Coverage Δ
routers/install.go 0% <0%> (ø) ⬆️
modules/setting/setting.go 46.91% <100%> (-0.28%) ⬇️
models/repo_indexer.go 45.54% <0%> (-3.47%) ⬇️
models/repo.go 37.82% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8805d...1a02504. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 1, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 1, 2017
@lafriks
Copy link
Member

lafriks commented Dec 1, 2017

LGTM
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 1, 2017
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Dec 1, 2017
@lunny
Copy link
Member

lunny commented Dec 1, 2017

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 1, 2017
@lunny lunny merged commit 57edc31 into go-gitea:master Dec 1, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

5 participants

@0rzech @codecov-io @lafriks @lunny @tboerger