Set OpenID support on by default when installing new instance #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
8 tasks
lunny requested changes Nov 28, 2017
modules/setting/setting.go Outdated
There was a problem hiding this comment.
But I think this should keep false. For a default installation, the minimal feature rule will keep system safer.
0rzech reviewed Nov 28, 2017
modules/setting/setting.go Outdated
There was a problem hiding this comment.
I think this should simply be
Service.EnableOpenIDSignIn = sec.Key("ENABLE_OPENID_SIGNIN").MustBool(!InstallLock) because InstallLock state seems to indicate whether this is fresh install or not, while Gitea creates app.ini itself during install process.
strk force-pushed the openid-default-on branch from f7c8db4 to 7686c02 Compare 
lafriks added backport/v1.3 type/bug and removed type/enhancement Partially fixes go-gitea#2984
strk force-pushed the openid-default-on branch from db47bb8 to 68fe411 Compare lunny approved these changes Nov 29, 2017
| LGTM |
tboerger added the lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
Codecov Report
@@ Coverage Diff @@ ## master #3010 +/- ## ======================================= Coverage 32.98% 32.98% ======================================= Files 270 270 Lines 39534 39534 ======================================= Hits 13042 13042 Misses 24637 24637 Partials 1855 1855
Continue to review full report at Codecov.
|
lafriks changed the title | @strk please send backport to 1.3 |
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Nov 29, 2017
lunny pushed a commit that referenced this pull request Nov 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Partially fixes #2984