Skip to content

Remove render issue link #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2017
Merged

Remove render issue link #2954

merged 2 commits into from
Nov 22, 2017

Conversation

makarchuk
Copy link
Contributor

While exploring the code I found function that is called multiple times but just copies the list.
As far as I understand there is no need to copy it, so I remove this function to make a code slightly more readable and nice.
@codecov-io
Copy link

Codecov Report

Merging #2954 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2954 +/- ## ========================================= - Coverage 26.82% 26.8% -0.02%  ========================================= Files 90 90 Lines 17807 17807 ========================================= - Hits 4777 4774 -3  - Misses 12351 12353 +2  - Partials 679 680 +1
Impacted Files Coverage Δ
modules/process/manager.go 69.56% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea78a6d...4c0db36. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 22, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 22, 2017
@lunny
Copy link
Member

lunny commented Nov 22, 2017

LGTM
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 22, 2017
@appleboy
Copy link
Member

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2017
@lafriks lafriks merged commit dbb7715 into go-gitea:master Nov 22, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

6 participants

@makarchuk @codecov-io @lunny @appleboy @tboerger @lafriks