Skip to content

Fix fork repository cycle to self #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2017
Merged

Fix fork repository cycle to self #2860

merged 2 commits into from
Nov 6, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 5, 2017

Will fix #2858
@lunny lunny added the type/bug label Nov 5, 2017
@lunny lunny added this to the 1.3.0 milestone Nov 5, 2017
@codecov-io
Copy link

codecov-io commented Nov 5, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ff9daa3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2860 +/- ## ========================================= Coverage ? 26.85% ========================================= Files ? 89 Lines ? 17607 Branches ? 0 ========================================= Hits ? 4728 Misses ? 12193 Partials ? 686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9daa3...bf442d4. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 5, 2017
ethantkoenig
ethantkoenig reviewed Nov 5, 2017
View reviewed changes
routers/repo/pull.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please use a more descriptive name than testForkRepo. Perhaps traverseParentRepo?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.
@lunny lunny force-pushed the lunny/fix_fork_to_self branch from 35e4064 to bf442d4 Compare November 6, 2017 01:05
@ethantkoenig
Copy link
Member

LGTM
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2017
@lafriks
Copy link
Member

lafriks commented Nov 6, 2017

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2017
@lunny lunny merged commit cdc4600 into go-gitea:master Nov 6, 2017
@lunny lunny deleted the lunny/fix_fork_to_self branch November 6, 2017 04:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

5 participants

@lunny @codecov-io @ethantkoenig @lafriks @tboerger