Skip to content

Fix removing backslash before quotes in translations #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2017
Merged

Fix removing backslash before quotes in translations #2831

merged 2 commits into from
Nov 2, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 2, 2017

Current translations commited by drone are still broken. This should fix that.
@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Nov 2, 2017
@lafriks lafriks added this to the 1.3.0 milestone Nov 2, 2017
@codecov-io
Copy link

codecov-io commented Nov 2, 2017 •
edited
Loading

Codecov Report

Merging #2831 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2831 +/- ## ======================================= Coverage 26.84% 26.84% ======================================= Files 89 89 Lines 17608 17608 ======================================= Hits 4727 4727 Misses 12195 12195 Partials 686 686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f04c00...e9b5735. Read the comment docs.
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Nov 2, 2017

LGTM
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2017
@Morlinest
Copy link
Member

LGTM
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2017
@lafriks lafriks force-pushed the fix/crowdin_tr_fix branch from 07e4d53 to 5113d87 Compare November 2, 2017 22:03
@lafriks lafriks merged commit 9500ad1 into go-gitea:master Nov 2, 2017
@lafriks lafriks deleted the fix/crowdin_tr_fix branch November 2, 2017 23:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

5 participants

@lafriks @codecov-io @bkcsoft @Morlinest @tboerger