Fix commits page url #2823
Merged
Fix commits page url #2823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #2823 +/- ## ======================================= Coverage 26.84% 26.84% ======================================= Files 89 89 Lines 17608 17608 ======================================= Hits 4727 4727 Misses 12195 12195 Partials 686 686Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 
lafriks reviewed Nov 1, 2017
templates/repo/sub_menu.tmpl Outdated
| {{if and (.Repository.UnitEnabled $.UnitTypeCode) (not .IsBareRepo)}} | ||
| <div class="item{{if .PageIsCommits}} active{{end}}"> | ||
| <a href="{{.RepoLink}}/commits/{{EscapePound .BranchName}}"><i class="octicon octicon-history"></i> <b>{{.CommitsCount}}</b> {{.i18n.Tr "repo.commits"}}</a> | ||
| <a href="{{.RepoLink}}/commits/branch/{{EscapePound .BranchName}}"><i class="octicon octicon-history"></i> <b>{{.CommitsCount}}</b> {{.i18n.Tr "repo.commits"}}</a> |
There was a problem hiding this comment.
Shouldn't there needs to be url depending on what page you are browsing (tags/commits/branches)?
There was a problem hiding this comment.
You are right, I have to do check for tags.
| @lafriks Done. |
| LGTM |
tboerger added lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #2805.