Configurable SSH key exchange algorithm and MAC suite #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lafriks requested changes Oct 30, 2017
There was a problem hiding this comment.
Please add also defaults in code like for chippers here: https://github.com/cumgun/gitea/blob/33711b6a963ee5fc5b836acc6cc1c9f577493a16/modules/setting/setting.go#L114
| @lafriks done |
tboerger added the lgtm/need 2 
Codecov Report
@@ Coverage Diff @@ ## master #2806 +/- ## ======================================= Coverage 26.84% 26.84% ======================================= Files 89 89 Lines 17608 17608 ======================================= Hits 4727 4727 Misses 12195 12195 Partials 686 686Continue to review full report at Codecov.
|
lafriks approved these changes Oct 31, 2017
| LGTM |
tboerger added lgtm/need 1 
sapk reviewed Nov 2, 2017
| if len(serverCiphers) > 0 { | ||
| SSH.ServerCiphers = serverCiphers | ||
| } | ||
| serverKeyExchanges := sec.Key("SSH_SERVER_KEY_EXCHANGES").Strings(",") |
There was a problem hiding this comment.
~~~For example if SSH_SERVER_KEY_EXCHANGES is not set. serverKeyExchanges = "," -> len(serverKeyExchanges) > 0 == true~~~ sapk approved these changes Nov 2, 2017
| LGTM |
tboerger added lgtm/done 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add new configuration keys
SSH_SERVER_KEY_EXCHANGESandSSH_SERVER_MACSin order to configure key exchange algorithm and MAC suite.