Add Safari pinned tab icon #2799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closes go-gitea#2753 Signed-off-by: Bastian Rinsche <bastian.rinsche@gmail.com>
| LGTM |
tboerger added the lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
Codecov Report
@@ Coverage Diff @@ ## master #2799 +/- ## ======================================= Coverage 26.86% 26.86% ======================================= Files 89 89 Lines 17596 17596 ======================================= Hits 4727 4727 Misses 12183 12183 Partials 686 686Continue to review full report at Codecov.
|
appleboy approved these changes Oct 29, 2017
ericek111 added a commit to ericek111/repman that referenced this pull request Oct 20, 2020
icon taken from: go-gitea/gitea#2799
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #2753
I had to manually create the .svg because the transformation is not that trivial, the viewBox has to be 0 0 16 16 but just rescaling it resulted in an icon that looked too small so I made it as large as possible within the constraints, the icon also has to be black because the color gets set separately as described here here. I also cleaned it with svgcleaner.
If it has to be generated from the logo feel free to close this.