Link members and repositories count to each page on org home. #2787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #2787 +/- ## ======================================= Coverage 26.85% 26.85% ======================================= Files 89 89 Lines 17607 17607 ======================================= Hits 4728 4728 Misses 12193 12193 Partials 686 686Continue to review full report at Codecov.
|
tboerger added the lgtm/need 2 | Add screenshot for demonstration.
|
Morlinest reviewed Nov 3, 2017
| <p class="text grey">{{.NumMembers}} {{$.i18n.Tr "org.lower_members"}} · {{.NumRepos}} {{$.i18n.Tr "org.lower_repositories"}}</p> | ||
| <p class="text grey"> | ||
| <a href="{{$.OrgLink}}/teams/{{.LowerName}}"><strong>{{.NumMembers}}</strong> {{$.i18n.Tr "org.lower_members"}}</a> · | ||
| <a href="{{$.OrgLink}}/teams/{{.LowerName}}/repositories"><strong>{{.NumRepos}}</strong> {{$.i18n.Tr "org.lower_repositories"}}</a> |
There was a problem hiding this comment.
Looks good but I am not sure about adding <strong>. For me it doesn't look nice.
lafriks added type/enhancement 
| LGTM |
tboerger added lgtm/need 1 
| LGTM |
tboerger added lgtm/done 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As title, for save clicks to org's members and repositories page.